[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32637: 27.0.50; window-size-change-functions not run from local hook

From: martin rudalics
Subject: bug#32637: 27.0.50; window-size-change-functions not run from local hook
Date: Thu, 06 Sep 2018 09:05:28 +0200

> It seems what you describe is inefficiency of the current implementation,
> but currently I have nothing to say about it, sorry.  What I see is that
> the same logic needs to be applied to both window-configuration-change-hook
> and window-size-change-functions.

From an application programmer's view the expected behavior of running
'window-size-change-functions' buffer-locally would be to call the
function (1) only if a window displays the buffer now and (2) only if
the size of that window actually changed.  And it should call the
function with that window as argument.  Which means that for any
buffer the function could be called as many times as a window showing
the buffer has changed its size.  It also means that we don't call the
function when a buffer has disappeared from the frame.

Now since the argument of 'window-size-change-functions' is the
associated frame, I agree with Eli that running it buffer-locally
doesn't make much sense.  The apparent gain in convenience is dwarfed
by the fact that one would still have to find the window(s) showing
the buffer.

And I still think that running 'window-configuration-change-hook'
buffer-locally in its current from hardly makes sense either: For
example, we don't call it for a buffer when that buffer has been
removed from a window which incidentally is the case that would allow
Man to remove its function from 'window-configuration-change-hook'.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]