bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffe


From: Noam Postavsky
Subject: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F
Date: Tue, 18 Sep 2018 18:46:59 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Ivan Shmakov <address@hidden> writes:

>  >> +          (terpri (current-buffer) t)
>
>  > This looks like you’re adding an extra newline,
>
>       Only if there’s none already, as the second argument to terpri
>       is non-nil.  Which can happen, for example, should user edit the
>       buffer manually (for whatever reason.)

Oh, right.  I don't use terpri so much, so I'd forgotten about that
handy feature.

>       Please consider the revised patch MIMEd.
>
>       FTR, a ‘side effect’ of this change is that rcirc-debug no
>       longer returns the string appended to buffer.  (Instead, it
>       returns the marker coinciding with point.)  AFAICT, the return
>       value of this function is never used in the Rcirc code.

I think that's fine, please push to master.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]