bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29923: [PATCH] Skip writing empty abbrev tables


From: Andreas Röhler
Subject: bug#29923: [PATCH] Skip writing empty abbrev tables
Date: Wed, 19 Sep 2018 08:04:11 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 19.09.2018 04:55, Allen Li wrote:
On Tue, Sep 18, 2018 at 3:53 PM Noam Postavsky <address@hidden> wrote:

Allen Li <address@hidden> writes:

The system abbrev omitting worked (if readable is nil); it's
implemented in abbrev--write.
However, that doesn't allow us to skip writing a table if it only
contains system abbrevs;
we'll still see a table with abbrevs, write the opening of the
define-abbrev-table form,
and then realize in abbrev-write that all of the abbrevs are system abbrevs.

Ah, it would be good to have this information in the commit message, as
the patch is a bit confusing to read otherwise.

Done.  I have also removed the system abbrev check in abbrev--write since
it is redundant now and this is the only place it is called.


AFAIU

add-mode-abbrev expect a respective abbrev-table existing.

(add-abbrev
   (if only-global-abbrevs
       global-abbrev-table
     (or local-abbrev-table
         (error "No per-mode abbrev table")))

Will this still work?

Cheers,
Andreas







reply via email to

[Prev in Thread] Current Thread [Next in Thread]