[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32994: 27.0.50; Regression in image type auto-detection

From: Juri Linkov
Subject: bug#32994: 27.0.50; Regression in image type auto-detection
Date: Tue, 09 Oct 2018 01:08:13 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

Tags: patch

A recent change in image-mode.el broke a useful feature that
automatically detects an image type, so now visiting an image file
without a file extension signals the error "upcase(nil) -
(wrong-type-argument char-or-string-p nil)".  This patch fixes it:

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 19fa28d440..eb7b410f4a 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -781,8 +785,9 @@ image-toggle-display-image
 (defun image--imagemagick-wanted-p (filename)
   (and (fboundp 'imagemagick-types)
        (not (eq imagemagick-types-inhibit t))
-       (not (memq (intern (upcase (file-name-extension filename)) obarray)
-                  imagemagick-types-inhibit))))
+       (not (and (file-name-extension filename)
+                 (memq (intern (upcase (file-name-extension filename)) obarray)
+                       imagemagick-types-inhibit)))))
 (defun image-toggle-hex-display ()
   "Toggle between image and hex display."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]