[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33065: [PATCH]: Eliminate obtrusive ghost cursors in follow mode in

From: Alan Mackenzie
Subject: bug#33065: [PATCH]: Eliminate obtrusive ghost cursors in follow mode in GUIs.
Date: Tue, 16 Oct 2018 16:20:58 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

Hello, Emacs.

In X Windows (amd probably other GUIs), when follow mode is active, and
the cursor passes from one follow window to another, an objectionable
hollow block cursor is left behind.  (At least, I personally find it
objectionable.  :-)  

The following patch (to the master branch) ameliorates this by creating
buffer local values of cursor-in-non-selected-windows and setting these
to nil when one of the buffer's windows is selected.

This is, of course, controlled by a boolean option, which I propose to
enable by default.

Yes, this will need an entry in NEWS, too.


diff --git a/lisp/follow.el b/lisp/follow.el
index e2d3a11b65..c04e787919 100644
--- a/lisp/follow.el
+++ b/lisp/follow.el
@@ -311,6 +311,17 @@ follow-auto
           (remove-hook 'find-file-hook 'follow-find-file-hook))
         (set-default symbol value)))
+(defcustom follow-hide-ghost-cursors t  ; Maybe this should be nil.
+  "When non-nil, Follow mode attempts to hide the obtrusive cursors
+in the non-selected windows of a window group.
+This variable takes effect when `follow-mode' is initialized.
+Due to limitations in Emacs, this only operates on the followers
+of the current window."
+  :type 'boolean
+  :group 'follow)
 (defvar follow-cache-command-list
   '(next-line previous-line forward-char backward-char right-char left-char)
   "List of commands that don't require recalculation.
@@ -427,6 +438,8 @@ follow-mode
         (when isearch-lazy-highlight
           (setq-local isearch-lazy-highlight 'all-windows))
+        (when follow-hide-ghost-cursors
+          (setq-local cursor-in-non-selected-windows nil))
         (setq window-group-start-function 'follow-window-start)
         (setq window-group-end-function 'follow-window-end)
@@ -456,6 +469,8 @@ follow-mode
     (kill-local-variable 'window-group-end-function)
     (kill-local-variable 'window-group-start-function)
+    (kill-local-variable 'cursor-in-non-selected-windows)
     (remove-hook 'ispell-update-post-hook 'follow-post-command-hook t)
     (remove-hook 'replace-update-post-hook 'follow-post-command-hook t)
     (remove-hook 'isearch-update-post-hook 'follow-post-command-hook t)
@@ -1262,6 +1277,10 @@ follow-avoid-tail-recenter
 ;;; Pre Display Function
+(defvar follow-prev-buffer nil
+  "The current buffer at the last call to `follow-adjust-window' or nil.
+follow-mode is not necessarily enabled in this buffer.")
 ;; This function is added to `pre-display-function' and is thus called
 ;; before each redisplay operation.  It supersedes (2018-09) the
 ;; former use of the post command hook, and now does the right thing
@@ -1310,6 +1329,24 @@ follow-post-command-hook
 (defun follow-adjust-window (win)
   ;; Adjust the window WIN and its followers.
   (cl-assert (eq (window-buffer win) (current-buffer)))
+  ;; Have we moved out of or into a follow-mode window group?
+  ;; If so, attend to the visibility of the cursors.
+  (when (not (eq (current-buffer) follow-prev-buffer))
+    ;; Do we need to switch off cursor handling in the previous buffer?
+    (when (buffer-live-p follow-prev-buffer)
+      (with-current-buffer follow-prev-buffer
+        (when (and follow-mode
+                   (local-variable-p 'cursor-in-non-selected-windows))
+          (setq cursor-in-non-selected-windows
+                (default-value 'cursor-in-non-selected-windows)))))
+    ;; Do we need to switch on cursor handling in the current buffer?
+    (when (and follow-mode
+               (local-variable-p 'cursor-in-non-selected-windows))
+      (setq cursor-in-non-selected-windows nil))
+    (when (buffer-live-p (current-buffer))
+      (setq follow-prev-buffer (current-buffer))))
   (when (and follow-mode
              (not (window-minibuffer-p win)))
     (let ((windows (follow-all-followers win)))

Alan Mackenzie (Nuremberg, Germany).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]