[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33006: 27.0.50; `dired-do-find-regexp' doesn't work for remote direc
bug#33006: 27.0.50; `dired-do-find-regexp' doesn't work for remote directories
Fri, 26 Oct 2018 17:18:03 +0200
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Dmitry Gutov <address@hidden> writes:
> Hi Michael,
> The patch doesn't look dangerous to me, so you can go ahead and
> install, thank you.
Thanks for reviewing.
> There is, however, a possible inconsistency: it touches
> xref--collect-matches-1, which is used both in xref-collect-matches
> and xref-collect-references. And you only changed the former function.
> Could you check that M-x xref-find-references didn't work on remote
> directories before your patch anyway? If it did, though, please make
> sure that it continues to do so.
> Bonus points for fixing it, at least when Grep is used (the relevant
> file is lisp/cedet/semantic/symref/grep.el).
It doesn't work, indeed. symref/grep.el isn't aware of remote processes
(it uses call-process, for example). I've fixed this with the appended
Is it OK now to commit?
Best regards, Michael.
Description: Text document