bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33095: [PATCH] Add support in emacsclient for EMACS_SOCKET_NAME


From: Eli Zaretskii
Subject: bug#33095: [PATCH] Add support in emacsclient for EMACS_SOCKET_NAME
Date: Sat, 27 Oct 2018 12:27:29 +0300

> From: Daniel Pittman <address@hidden>
> Date: Fri, 19 Oct 2018 09:45:57 -0400
> 
> This patch implements EMACS_SOCKET_NAME in emacsclient, providing the
> same sort of "set the argument from the environment" feature for the
> socket name as for other features.

Thanks, pushed to the master branch.

A few minor nits for the future:

> If the `--socket-name` argument is unspecified, the environment
> variable `EMACS_SOCKET_NAME` is now consulted with the same

We don't use the markdown-style quoting `like this`, we use quoting
'like this' instead.

> semantics. This mirrors the behavior of the `--server-file` argument,

Please leave 2 spaces between sentences in documentation and comments.

Finally, it looks like your copyright assignment is only for rcp.el
and for Gnus, so I think we will need a general Emacs assignment to
accept your future contributions.  Please write to
address@hidden and ask him whether this is indeed so, as I
could be mistaken.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]