bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33043: [PATCH v1 1/1] Support for the truncation of displayed URLs


From: Basil L. Contovounesios
Subject: bug#33043: [PATCH v1 1/1] Support for the truncation of displayed URLs
Date: Sun, 28 Oct 2018 03:14:39 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Attachment: 0001-Add-URL-truncation-support-to-rcirc-bug-33043.patch
Description: Text Data

Attachment: 0002-Reuse-URL-truncation-function-in-rcirc-bug-33043.patch
Description: Text Data

Eli Zaretskii <address@hidden> writes:

>> From: "Basil L. Contovounesios" <address@hidden>
>> Date: Thu, 18 Oct 2018 11:38:04 +0100
>> Cc: address@hidden
>> 
>> > I didn't know about url-truncate-url-for-viewing, no other reason.
>> >
>> > I'd be happy with your change, but note that it will always truncate
>> > URLs that are wider than the current frame - there is no way to have no
>> > truncation take place.
>> >
>> > If a user is most familiar with something like ffap to open URLs then
>> > this is unfortunate - ffap doesn't see the full URL in the buffer.
>> 
>> Sorry, that was an oversight.  Here's how the last patch can be patched
>> to support the default of no truncation:
>
> If you two are in agreement wrt what should be installed, I'd need a
> full changeset from Basil to push.

I attach two patches.  The first comprises David's original patch, but
with an added :version tag and reworded commit message.  The second
switches to reusing url-truncate-url-for-viewing.  WDYT?

Thanks,

-- 
Basil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]