[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33263: 27.0.50; Tidying up Gnus modes

From: Noam Postavsky
Subject: bug#33263: 27.0.50; Tidying up Gnus modes
Date: Tue, 6 Nov 2018 11:28:17 -0500

On Tue, 6 Nov 2018 at 11:22, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:

> >>>> +(defvar gnus-browse-mode-map (make-keymap))
> >>>>
> >>>>  (unless gnus-browse-mode-map
> >>>> -  (setq gnus-browse-mode-map (make-keymap))
> >>>> +  (defvar gnus-browse-mode-map (make-keymap))

> Right, I got that much, I was mostly wondering why the `unless' -- it's
> unlikely these files would be loaded multiple times, and even if they
> were, that wouldn't break anything, would it?

Without the `unless', if the user had made changes to
gnus-browse-mode-map they would be lost upon reload (as you say, it's
not especially likely to happen, but I guess the original author
wanted to preserve the semantics of the single defvar form).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]