[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug
From: |
Eli Zaretskii |
Subject: |
bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) |
Date: |
Mon, 17 Dec 2018 21:58:26 +0200 |
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 17 Dec 2018 20:20:11 +0100
> Cc: Philipp Stephani <phst@google.com>
>
> +@item :file-handler @var{file-handler}
> +If @var{file-handler} is non-@code{nil}, then look for a file name
> +handler for the current buffer's @code{default-directory}
... and invoke that file handler to make the process.
> + If there
> +is no such handler, proceed as if @var{file-handler} were nil.
^^^
That "nil" should be in @code.
> +** 'make-process' now takes a keyword argument ':file-handler'; if
> +that is non-nil, it will look for a file name handler for the current
> +buffer's 'default-directory'.
Likewise.
> +:file-handler FILE-HANDLER -- If FILE-HANDLER is non-nil, then look
> +for a file name handler for the current buffer's `default-directory'.
Likewise.
> + (skip-unless (file-accessible-directory-p "/:/bin/"))
I don't see why we should skip important tests on platforms where
there's no /bin. Isn't it possible to use the Emacs binary here (and
elsewhere in the tests you add), as I suggested?
Thanks.
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/16
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691),
Eli Zaretskii <=
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/23