[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33567: Syntactic fontification of diff hunks

From: Dmitry Gutov
Subject: bug#33567: Syntactic fontification of diff hunks
Date: Wed, 19 Dec 2018 02:48:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0

On 19.12.2018 2:11, Juri Linkov wrote:

Does it help to remove foreground colors from diff-added and diff-removed?

Yup. Except if I customize those and restart, I think the +'s and -'s on the left will become black as well, which is somewhat of a loss. So the colors might need to be moved to other definitions, e.g. diff-indicator-added.

Further, I'm not sure if we should do the same to the look of the diff-mode buffers when diff-font-lock-syntax is nil. Just something to consider.

Third, third-party code might rely on those faces looking as they do now. E.g. in diff-hl, diff-hl-insert inherits from diff-added, although this package likely won't be affected by this change (the faces define their own :foreground, for reasons lost to history).

Neither GitHub nor GitLab have foreground green/red colors, only background
green/red colors.

Those are the interfaces that built up my expectations as well.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]