bug#33669: 26.1; Buffer-menu-mode bad UX

[Eli Zaretskii]

> From: Devon Sean McCullough <Emacs-Hacker2018@jovi.net>
> Date: Sat, 5 Jan 2019 10:36:22 -0500
> 
> > On Jan 5, 2019, at 3:44 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Ping!  Ping!  Devon, could you please try the proposed fix?
> 
> The original and patched versions both look problematic.  Instead, I had good 
> results with
> 
> --- old/buff-menu.el  2019-01-05 10:26:45.000000000 -0500
> +++ new/buff-menu.el  2019-01-05 10:27:23.000000000 -0500
> @@ -475,10 +475,10 @@
>                          (save-buffer))
>                        (tabulated-list-set-col 2 " " t))
>                    (error (warn "Error saving %s" buffer))))
> -              (if delete
> -                  (unless (eq buffer (current-buffer))
> -                    (kill-buffer buffer)
> -                    (tabulated-list-delete-entry))
> +              (if (and delete
> +                       (not (eq buffer (current-buffer)))
> +                          (kill-buffer buffer))
> +                     (tabulated-list-delete-entry)
>                  (forward-line 1)))))))))
>  
>  (defun Buffer-menu-select ()
> 

Thanks, pushed to the emacs-26 branch.