bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34479: Incorrect classification of messages in compilation-mode buff


From: Eli Zaretskii
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Fri, 01 Mar 2019 12:07:24 +0200

> From: Tobias Bading <tbading@web.de>
> Date: Mon, 25 Feb 2019 14:26:38 +0100
> Cc: Daniel Lopez <daniel.lopez999@gmail.com>,
>  Eli Zaretskii <eliz@gnu.org>
> 
> I also discovered this bug a few days ago and came up with the same fix as 
> Daniel. However, there’s a small mistake in his patch which results in 
> incorrect error numbers in the mode line. The compilation--note-type call 
> should look like this:
> 
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 146af5a..368b088 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -1441,7 +1441,7 @@ compilation-parse-errors
>                (let ((this-type (if (consp type)
>                                     (compilation-type type)
>                                   (or type 2))))
> -                (compilation--note-type type)
> +                (compilation--note-type this-type)
>  
>                  (compilation--put-prop
>                   file 'font-lock-face

Thanks, pushed to the emacs-26 branch.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]