[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34710: the mode line flicks on set-window-vscroll
From: |
Tak Kunihiro |
Subject: |
bug#34710: the mode line flicks on set-window-vscroll |
Date: |
Thu, 07 Mar 2019 09:25:18 +0900 (JST) |
With my casual test, the patch makes pixel-wise scroll 5% faster.
> On Mar 6, 2019, at 17:06 , Alan Third <alan@idiocy.org> wrote:
>
> On Tue, Mar 05, 2019 at 06:09:41PM +0100, Robert Pluim wrote:
>> Robert Pluim <rpluim@gmail.com> writes:
>>
>>> so not 4k, and I normally run with multiple non-maximized frames (but
>>> my testing was with a single default frame).
>>
>> So Iʼve decided that this was all down to key-repeat rate. I had that
>> set to maximum already, but I went into system preferences, set it
>> lower, exited emacs, set it back, and now emacs with your patch is OK.
>
> Good to know, but still sounds like performance could be improved.
>
> And I still can’t replicate it. Perhaps it’s a combination of multiple
> factors.
>
> Can you try this patch and see if it improves anything, please?
>
> modified src/nsterm.m
> @@ -1168,7 +1168,6 @@ static NSRect constrain_frame_rect(NSRect frameRect,
> bool isFullscreen)
>
> #ifdef NS_IMPL_COCOA
> [NSGraphicsContext setCurrentContext:nil];
> - [view display];
> #else
> block_input ();
>
> It’s possible this will cause it to drop frames and make things worse.
- bug#34710: the mode line flicks on set-window-vscroll, (continued)
- bug#34710: the mode line flicks on set-window-vscroll, Alan Third, 2019/03/02
- bug#34710: the mode line flicks on set-window-vscroll, Tak Kunihiro, 2019/03/02
- bug#34710: the mode line flicks on set-window-vscroll, Robert Pluim, 2019/03/04
- bug#34710: the mode line flicks on set-window-vscroll, Alan Third, 2019/03/04
- bug#34710: the mode line flicks on set-window-vscroll, Robert Pluim, 2019/03/04
- bug#34710: the mode line flicks on set-window-vscroll, Alan Third, 2019/03/04
- bug#34710: the mode line flicks on set-window-vscroll, Robert Pluim, 2019/03/05
- bug#34710: the mode line flicks on set-window-vscroll, Robert Pluim, 2019/03/05
- bug#34710: the mode line flicks on set-window-vscroll, Alan Third, 2019/03/06
- bug#34710: the mode line flicks on set-window-vscroll, Robert Pluim, 2019/03/06
bug#34710: the mode line flicks on set-window-vscroll,
Tak Kunihiro <=