bug#34908: Push mark in xref-push-marker-stack

[João Távora]

This looks good to me, but I'm no expert

On a tangent, I'm a little ashamed that I didn't know
about C-u C-SPC until now (the docstring could be
clearer). It does basically a `pop-to-mark-command`
right? I wonder how many more of these nuggets
of original Emacs UI are hidden and where...

Anyway, thanks!
João

On Mon, Mar 18, 2019 at 9:25 PM Juri Linkov <juri@linkov.net> wrote:
>
> X-Debbugs-CC: João Távora <joaotavora@gmail.com>, Dmitry Gutov 
> <dgutov@yandex.ru>
>
> Shouldn't xref-push-marker-stack push the mark like all normal commands do?
>
> I know there is ‘M-,’ but why not allow using the standard keys
> ‘C-x C-SPC’ (pop-global-mark) and ‘C-u C-SPC’ (in the same file)
> as well?
>
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index 6974d00048..861e24a85f 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -365,6 +365,7 @@ xref-set-marker-ring-length
>
>  (defun xref-push-marker-stack (&optional m)
>    "Add point M (defaults to `point-marker') to the marker stack."
> +  (push-mark nil t)
>    (ring-insert xref--marker-ring (or m (point-marker))))
>
>
>


-- 
João Távora