[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34781: 27.0.50; integer in pcase sometimes compared by eq

From: Mattias Engdegård
Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq
Date: Thu, 28 Mar 2019 22:51:39 +0100
User-agent: Evolution 3.30.5 (3.30.5-1.fc29)

tor 2019-03-28 klockan 13:30 -0700 skrev Paul Eggert:

> If we have the bounds, then portable-fixnum-p is merely a
> convenience, no?

Yes. We can drop it if you prefer it to be open-coded in pcase and
elsewhere, but I thought the predicate would make sense.

> I'd prefer the names most-negative-portable-fixnum and
> most-positive-portable-fixnum. Their documentation should make it
> clear
> what the portability test is for. Presumably the test applies just to
> this version of Emacs, since future versions might change the
> portable
> fixnum bounds.

Here is a patch for that, and an updated pcase patch.

Attachment: 0001-Add-bounds-for-portable-fixnums-and-portable-fixnum-.patch
Description: Text Data

Attachment: 0002-Don-t-match-integers-with-memq-in-pcase.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]