[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34847: 27.0.50; auto-revert-buffers occasionally selects a killed bu
bug#34847: 27.0.50; auto-revert-buffers occasionally selects a killed buffer
Sat, 06 Apr 2019 11:37:38 +0200
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
"Basil L. Contovounesios" <address@hidden> writes:
>> ! (defun auto-revert-remove-current-buffer (&optional buffer)
>> "Remove dead buffer from `auto-revert-buffer-list'."
> Can you please update the docstring? E.g.
> "Remove BUFFER from `auto-revert-buffer-list'.
> BUFFER defaults to `current-buffer'."
>> --- 772,783 ----
>> (setq bufs (delq nil
>> (lambda (buf)
>> ! (and (buffer-live-p buf)
>> ! (with-current-buffer buf
>> ! (and
>> ! (or (not (file-remote-p
>> ! (file-remote-p default-directory nil
>> ! buf))))
>> ;; Partition `bufs' into two halves depending on whether or not
>> ;; the buffers are in `auto-revert-remaining-buffers'. The
> Indentation seems a bit off here. Note that you can use 'when' instead
> of 'and' to fit more easily within 80 columns, if you prefer.
I'd like to keep it, for simpler diffs when time comes. There's no
problem with the 80 columns width.
> Otherwise LGTM. Can you please also make the following change while
> you're at it?
> diff --git a/lisp/autorevert.el b/lisp/autorevert.el
> index bc7c616ecb..d736f0d31c 100644
> --- a/lisp/autorevert.el
> +++ b/lisp/autorevert.el
> @@ -509,7 +509,7 @@ auto-revert-notify-rm-watch
> (file-notify-rm-watch auto-revert-notify-watch-descriptor)))))
> - (remove-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch))
> + (remove-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch t))
> (setq auto-revert-notify-watch-descriptor nil
> auto-revert-notify-modified-p nil))
Good catch! I've applied it.
> Works for me; I hope to see it land soon. See also my other message for
> a related but more subtle problem: https://debbugs.gnu.org/34847#16
Eli has already confirmed your approach, so you might commit it (and
close the bug then).
Best regards, Michael.