[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35141: Add a default action to erc-desktop-notifications to switch t
bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer
Sat, 6 Apr 2019 20:22:38 +1030
Done - see attached. Thanks again for your help.
On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios <address@hidden
Alex Murray <address@hidden> writes:
> Thanks for the review - see attached for an updated version based on your feedback.
I just tried byte-compiling the patched file and got the following
In toplevel form:
Warning: Unused lexical argument ‘proc’
Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.
Description: Text Data