bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35062: [PATCH v3 1/3] Remove redundant comparison


From: Eli Zaretskii
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Sat, 13 Apr 2019 22:19:12 +0300

> Date: Sat, 13 Apr 2019 21:28:39 +0300
> From: Konstantin Kharlamov <address@hidden>
> Cc: address@hidden
> 
> >> http://git.savannah.gnu.org/cgit/emacs.git/log/?qt=author&q=Konstantin
> >>  there is no my contribution.
> >> 
> >>  More over: you didn't even tell me! Wow! This is not good.
> > 
> > What do you mean?  Your name is in the log.
> 
> If you click the link above you won't find it. The only mention of my 
> name is in log message as "suggested-by".

If you are looking at partial information, don't be surprised that you
see only some part of what was done and written.  Emacs contributors
are generally expected to have a clone of the repository on their
local machine.  Don't you have it?

> Which btw sounds like I reported a bug "hey guys, I don't know how
> to code, but static analyzer says this part can be improved, can
> anybody do it for me?".

That's not what it means.  "Suggested by" means you suggested a code
change, but I tweaked it enough to feel that you can no longer be held
responsible for whatever mistakes I might have made in the actual code
change I committed.  And I explicitly said that this is what I did: "I
pushed a slightly different change along the same lines."  There's
also a reference to the bug number, where what you submitted is
clearly visible.  The "I don't know how to code" variant would have
been identified as "reported by" instead.

This is all standard practice around here (and in other projects as
well).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]