bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35062: [PATCH v3 1/3] Remove redundant comparison


From: Konstantin Kharlamov
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Mon, 15 Apr 2019 09:49:08 +0300



On Вс, Apr 14, 2019 at 23:38, Richard Stallman <address@hidden> wrote:
[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  >   "Suggested by" means you suggested a code
> change, but I tweaked it enough to feel that you can no longer be held > responsible for whatever mistakes I might have made in the actual code
  > change I committed.

I think you're saying that "suggested by" means that the code changes
were suggested by that person -- not merely that the idea was
suggested by per.  Is that it?

That's what you quoted :)

IMO in such situations (i.e. when original changes were commited without any modification anyway) would be nice to commit the original patch, and then add up further improvements as 2-nd commit. Ultimately what makes me sad is that if I'd want to refer to my commits in Emacs as part of a CV, it's hard to find all suggested-by and authored commits at the same time, and also that suggested-by sounds kind of vague to have an influence in CV.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]