bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35062: [PATCH v3 1/3] Remove redundant comparison


From: Konstantin Kharlamov
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Mon, 15 Apr 2019 18:01:35 +0300



On Пн, Apr 15, 2019 at 17:32, Eli Zaretskii <address@hidden> wrote:
 Date: Mon, 15 Apr 2019 09:49:08 +0300
 From: Konstantin Kharlamov <address@hidden>
 Cc: Eli Zaretskii <address@hidden>, address@hidden

 IMO in such situations (i.e. when original changes were commited
without any modification anyway) would be nice to commit the original
 patch, and then add up further improvements as 2-nd commit.

That's true, but this is not such a situation: the original changes
were never committed without any modifications.

Well, given the line my patch modifies has no changes, the only modification was the commit message. My only mistake was not knowing that UTF8 is prohibited. But really, it's a 2 symbols text replacement, me or you could just replace it.

Sometimes committing the original and then making changes in a
followup is TRT, and sometimes it isn't; it's a judgment call.  In
general, the decision depends on the percentage of the original
submission that the committer would like to change, and also on the
overall volume of the original submission.  In this case, the original
patch was relatively small, and I modified it in relatively
significant ways.  So it made little sense to commit something that
would be immediately modified in significant ways, it would just be
extra work for no good reason.

Is there an extra work? The changes you added can be commited with α) git commit --amend -v, or β) git commit -v. You did α, which only differs from β by a number of characters, that is ironically smaller in β.

 Ultimately what makes me sad is that if I'd want to refer to my
 commits in Emacs as part of a CV, it's hard to find all suggested-by
 and authored commits at the same time, and also that suggested-by
 sounds kind of vague to have an influence in CV.

You can always use "git log --grep" to find references to your
contributions in the log messages.  And the log message includes a
reference to the bug number, where you can refer people for your
actual contribution.

Who would attach a bunch of commit messages to a CV? It's unreliable (interviewer gotta check that these indeed are mine), and also they gonna bloat CV for no reason. A better way would be providing a web-link to a repository with commits.

----

Sorry, I actually feel embarassed that I discussing a trivial one-liner patch :D But I can't stop thinking that this could've happened with a non-one-line or maybe one-line but non-trivial contribution…







reply via email to

[Prev in Thread] Current Thread [Next in Thread]