[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35062: [PATCH v3 1/3] Remove redundant comparison

From: Konstantin Kharlamov
Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison
Date: Mon, 15 Apr 2019 20:29:03 +0300

В Пн, апр 15, 2019 at 20:16, Eli Zaretskii <address@hidden> написал:
 Date: Mon, 15 Apr 2019 20:03:05 +0300
 From: Konstantin Kharlamov <address@hidden>
 Cc: address@hidden, address@hidden

> No, the log message was not the problem. Look at the code changes,
 > they were the ones I modified.

The line that I changed is exactly the same. What you did is cleaning
 up the function even further, however that didn't touch my
modifications. Your modification is not strictly relevant to my patch.

That's your perspective, but not mine.  My perspective is that you
changed one line, whereas I changed 3, and by that also changed the
overall logic of the tests.

Right, does that contradict to my statement? Your changes and mine are independent entities that can exist one without the other.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]