[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35287: dired-do-copy English beef-up

From: Juri Linkov
Subject: bug#35287: dired-do-copy English beef-up
Date: Wed, 24 Apr 2019 23:15:13 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

>> Then a complete set of messages:
>>   Copy: 3 files done
>>   Copy: 2 of 3 files skipped
>>   Copy: 2 of 3 files failed
>>   Copy: 2 files in 3 requests failed
> What is the difference between the last two?

The latter is used for recursive operations.

> What about the current existing messages when
> there are failures, telling you to use `?' to
> see the details (the `dired-log' output)?

This is now unified as well:

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index b81c0d1a4f..e967f94e06 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1798,32 +1798,36 @@ dired-create-files
                  (push (dired-make-relative from)
-                 (dired-log "%s `%s' to `%s' failed:\n%s\n"
+                 (dired-log "%s: `%s' to `%s' failed:\n%s\n"
                             operation from to err))))))))
       (setq failures (nconc failures dired-create-files-failures))
-       (format "%s failed for %d file%s in %d requests"
-               operation (length failures)
-               (dired-plural-s (length failures))
-               total)
+       (format (ngettext "%s failed for %d file in %d requests"
+                        "%s failed for %d files in %d requests"
+                        (length failures))
+              operation (length failures) total)
-       (format "%s failed for %d of %d file%s"
-               operation (length failures)
-               total (dired-plural-s total))
+       (format (ngettext "%s: %d of %d file failed"
+                        "%s: %d of %d files failed"
+                        total)
+              operation (length failures) total)
-       (format "%s: %d of %d file%s skipped"
-               operation (length skipped) total
-               (dired-plural-s total))
+       (format (ngettext "%s: %d of %d file skipped"
+                        "%s: %d of %d files skipped"
+                        total)
+              operation (length skipped) total)
-      (message "%s: %s file%s"
-              operation success-count (dired-plural-s success-count)))))
+      (message (ngettext "%s: %d file done"
+                        "%s: %d files done"
+                        success-count)
+              operation success-count))))
 (defun dired-do-create-files (op-symbol file-creator operation arg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]