[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34915: 27.0.50; Wdired regression with ls -F

From: Stephen Berman
Subject: bug#34915: 27.0.50; Wdired regression with ls -F
Date: Fri, 26 Apr 2019 18:07:04 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

On Fri, 26 Apr 2019 14:56:57 +0100 "Basil L. Contovounesios" <address@hidden> 

> Stephen Berman <address@hidden> writes:
>> On Fri, 12 Apr 2019 15:06:18 +0200 Stephen Berman <address@hidden> wrote:
>>> On Fri, 12 Apr 2019 13:58:25 +0100 "Basil L. Contovounesios"
>>> <address@hidden> wrote:
>>>> Stephen Berman <address@hidden> writes:
>>>>> On Tue, 19 Mar 2019 13:43:16 +0000 "Basil L. Contovounesios"
>>>>> <address@hidden> wrote:
>>>>>> It seems like Wdired thinks the indicators added by ls (one of */=>@|)
>>>>>> are part of the file name now.
>>>>> This is indeed due to my changes.  The patch below appears to fix the
>>>>> problem, but I'm not sure how robust it is (I was also, and remain,
>>>>> unsure about my handling of symlinks in the previous patch, but I
>>>>> haven't found time to look at it more closely; at least I haven't seen
>>>>> any bug reports about it so far).
>>>> I can confirm your patch fixes the issue, thanks!
>>> Thanks for testing.  If there are no objections within a few days, I'll
>>> push it to master.
>> I didn't expect "a few days" to become almost two weeks, but I've
>> finally pushed the fix to master as commit 6d8e0fc5aa.  I slightly
>> changed the patch to account for using either the short or long form of
>> the indicator switch, and I added a test.
> Thanks.  I noticed an opportunity for a tiny bit of reuse:

I'm not sure the two uses justify a new function, but I don't oppose it.

> Which makes me wonder: is there no Dired function that
> wdired--restore-dired-filename-prop can reuse for finding the boundaries
> of a file name?  Is dired-move-to-end-of-filename not suitable?  It
> seems to perform similar checks for symlinks and --classify.

dired-move-to-end-of-filename doesn't work in wdired-mode because the
dired-filename text property it uses was removed to fix bug#32173, and
wdired--restore-dired-filename-prop was added to compensate.  I couldn't
come up with a more elegant solution.

Steve Berman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]