bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35418: [PATCH] Don't poll auto-revert files that use notification


From: Eli Zaretskii
Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification
Date: Mon, 29 Apr 2019 19:23:53 +0300

> From: Mattias Engdegård <address@hidden>
> Date: Mon, 29 Apr 2019 13:06:50 +0200
> Cc: Eli Zaretskii <address@hidden>, address@hidden
> 
> By the way, the organisation of this part of the manual could be improved -- 
> don't you agree?

Could be.

> There is a section called Reverting, which starts about `revert-buffer' but 
> then goes on to talk about the auto-revert, global-auto-revert and 
> auto-revert-tail modes and details about the mechanisms behind them: polling, 
> intervals, notification.
> 
> Then there is a (sibling) section called Autorevert, which despite its name 
> only talks about auto-reverting non-file buffers.

You say "section" but the names you cite are node names, not section
names.  The latter are slightly more descriptive.

> This can be reorganised in various ways. We could move all autorevert text to 
> a sibling node to Reverting, or to one or more child nodes. In any case, such 
> text shuffling should not be part of this patch.

I think we should have sibling sections "Reverting" and "Autorevert",
with the latter describing both types of auto-reverting.  And
"Reverting" should have a cross-reference to "Autorevert" for
automatic reverting of file-visiting buffers.

Would you like to submit a patch to that effect?

> > Saying this, the user option might need another name. What about
> > `auto-revert-also-poll'?
> 
> Naming is always hard. I started with `auto-revert-avoid-polling' but wanted 
> to avoid a negative name.
> I tried `auto-revert-also-poll' but it somehow didn't feel right; not all 
> buffers use notification.
> It is nothing I feel strongly about, so if you do prefer that name I'll 
> change, but I've kept the original name in the patch for now.

I actually think auto-revert-dont-poll is better, even though it's
negative.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]