bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35468: [PATCH] Refactor draw_glyph_string on X and w32


From: Alan Third
Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32
Date: Tue, 30 Apr 2019 21:11:29 +0100
User-agent: Mutt/1.11.3 (2019-02-01)

On Tue, Apr 30, 2019 at 07:59:37AM +0300, Eli Zaretskii wrote:
> > From: Alex Gramiak <address@hidden>
> > Cc: address@hidden
> > Date: Mon, 29 Apr 2019 11:43:23 -0600
> > 
> > It doesn't work for NS partially because of the following section only
> > present in the NS equivalent of gui_draw_glyph_string_box. Would you be
> > okay with putting this in the generic version inside a FRAME_NS_P (s->f)
> > check? I don't know why only NS has this, though...
> > 
> >   if (s->hl == DRAW_MOUSE_FACE)
> >     {
> >       face = FACE_FROM_ID_OR_NULL (s->f,
> >                                MOUSE_HL_INFO (s->f)->mouse_face_face_id);
> >       if (!face)
> >         face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
> >     }
> >   else
> >     face = s->face;
> 
> I don't know why this is TRT, either.  We could ask Alan to look into
> this, or we could simply remove that, as other terminals don't use
> box_line_width from the mouse face, they use s->face instead.

A quick test doesn’t turn up any immediate issues with removing this,
but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use.
-- 
Alan Third





reply via email to

[Prev in Thread] Current Thread [Next in Thread]