bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35468: [PATCH] Refactor draw_glyph_string on X and w32


From: Eli Zaretskii
Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32
Date: Wed, 01 May 2019 20:38:17 +0300

> Date: Tue, 30 Apr 2019 21:11:29 +0100
> From: Alan Third <address@hidden>
> Cc: Alex Gramiak <address@hidden>, address@hidden
> 
> > >   if (s->hl == DRAW_MOUSE_FACE)
> > >     {
> > >       face = FACE_FROM_ID_OR_NULL (s->f,
> > >                              MOUSE_HL_INFO (s->f)->mouse_face_face_id);
> > >       if (!face)
> > >         face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
> > >     }
> > >   else
> > >     face = s->face;
> > 
> > I don't know why this is TRT, either.  We could ask Alan to look into
> > this, or we could simply remove that, as other terminals don't use
> > box_line_width from the mouse face, they use s->face instead.
> 
> A quick test doesn’t turn up any immediate issues with removing this,
> but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use.

E.g., when you hover the mouse pointer above the mouse-sensitive
portions of the mode line.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]