bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect


From: João Távora
Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect
Date: Wed, 8 May 2019 00:10:11 +0100

On Tue, May 7, 2019 at 9:30 PM Juri Linkov <address@hidden> wrote:
>> Anyway, your initiative got my attention.  Do you remember what I
>> wrote previously?
>>
>>> [jt] I would even go as far as obsoleting the variable entirely, and
>>> use make-obsolete-variable instead: there's no real reason
>>> why newline should be given special treatment.  And users
>>> that need this for some obscure reason can probably plug it
>>> in post-self-insert-hook.
>>
>>> If you obsolete the variable, you can remove it from the
>>> manual, too.
>>
>> I still think this is the best option, so if you didn't already push that,
>> I would be thankful that you do. It should solve your issue and make
>> the code and manual simpler.
>
> I had doubts about removing it, but since you are sure about this,
> then please see the following patch attached.  If basically this is ok,
> I'll also change the manual, NEWS, etc.

Now the variable is obsoleted in master.

The patch is fine (but did you push it already?). I have a minor grammar
nit (you should connect both variables with "and" when you mention them
in comments and docstrings).

Also the manual and NEWS entries are missing.  Don't forget about those.

And thanks, of course :-)
João

reply via email to

[Prev in Thread] Current Thread [Next in Thread]