[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35624: log-view-diff regression
From: |
Eli Zaretskii |
Subject: |
bug#35624: log-view-diff regression |
Date: |
Mon, 13 May 2019 17:24:29 +0300 |
> From: Juri Linkov <juri@linkov.net>
> Cc: 35624@debbugs.gnu.org
> Date: Sun, 12 May 2019 22:15:20 +0300
>
> > I asked a detailed question, but your answer doesn't make me wiser
> > about what "e" means. Could you please humor me with a more detailed
> > answer?
>
> Let me describe how log-view-diff was supposed to work since its introduction
> ~20 years ago until its behavior was changed accidentally one and half year
> ago:
> when the user puts the beginning of the region on the line with one revision,
> and the end of the region on the line with another revision, the function
> 'log-view-diff-common' extracts the 'from' revision from the line
> with the first revision, and the 'to' revision from the line
> with the second revision.
Then the fix in bug#28466 makes no sense, because it treats the case
when the region ends on the last revision specially.
But I feel that I've exhausted my grace in trying to make sense out of
this, so I will now shut up.
> bug#28466 tried to improve the logic when the end of the region is
> at the end of the buffer
Treating EOB specially makes no sense to me, FWIW.
bug#35624: log-view-diff regression, Eli Zaretskii, 2019/05/08
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/08
- bug#35624: log-view-diff regression, Eli Zaretskii, 2019/05/10
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/11
- bug#35624: log-view-diff regression, Eli Zaretskii, 2019/05/11
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/12
- bug#35624: log-view-diff regression,
Eli Zaretskii <=
- bug#35624: log-view-diff regression, Dmitry Gutov, 2019/05/13
- bug#35624: log-view-diff regression, Eli Zaretskii, 2019/05/13