[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a
|
From: |
Juri Linkov |
|
Subject: |
bug#35695: 27.0.50; Faces diff-added and diff-removed look the same in a 256 color terminal |
|
Date: |
Tue, 14 May 2019 23:06:18 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
>> Thanks, diff-refine-added needs old values for 288 colors as well.
>
> I didn't include it since the output looked good with the new value.
> However, for consistency, we should probably add one for it as well.
>
> Should I include a comment describing why we need to treat 256 color
> displays differently?
Yes, comments are preferable because we don't have deffaces
with more than 88 min-colors anywhere else.