[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35770: [PATCH] Broken duplicate case elimination in switch byte-comp

From: Mattias Engdegård
Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation
Date: Fri, 17 May 2019 16:48:19 +0200
User-agent: Evolution 3.30.5 (3.30.5-1.fc29)

fre 2019-05-17 klockan 08:16 -0400 skrev Stefan Monnier:

> The patch looks fine, but could you add corresponding regression
> tests?

Added. I wasn't sure how you test these things, but I both added some
functional tests and some kind of check of the bytecode. If you find
the latter superfluous, I can drop it; I think the functional tests are
reliable enough. In other words, we have a case of miscompilation.

There was another bug in the original code which survived into the
first patch: the check for duplicate keys was done with `assq', which
of course doesn't work for stuff compared with `eql' or `equal'. Now

Attachment: 0001-Correctly-eliminate-duplicate-cases-in-switch-compil.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]