[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files'
From: |
Michael Heerdegen |
Subject: |
bug#30626: 26.0.91; Crash when traversing a `stream-of-directory-files' |
Date: |
Sun, 26 May 2019 02:32:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <npostavs@gmail.com> writes:
> >> > - stream-make should use cons instead of list (or maybe a struct?).
> >>
> >> I think cons would be ok. Would a struct make things slower?
>
> A struct might be slower, and cons has the advantage that the print
> output is more readable for humans too. E.g., with this code: [...]
I see no reason not to switch to cons. Better readable, and less cons
garbage than with `list'.
Would you like to do this?
> >> > - stream-empty should just be a constant.
> >>
> >> Dunno if there are cases where this would be problematic, but I
> >> guess we
> >> could do this as well.
>
> I've done this in the patch below. Passes all the tests, and I can't
> see why it would be problematic.
Looks good to me. Also passes my tests (which are all my stream.el
uses, including el-search.el).
> > @Nicolas: Do you want us to care about this or do you want to have a
> > look yourself? I don't want to hurry, I just don't want this to be
> > forgotten. If you say you have time in four months, it's still ok.
>
> Not getting any response; I'll wait another week for comments and then
> push.
Ok, let's do this.
Thanks,
Michael.