[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20148: 24.4: function `bookmark-get-bookmark'
From: |
Basil L. Contovounesios |
Subject: |
bug#20148: 24.4: function `bookmark-get-bookmark' |
Date: |
Thu, 30 May 2019 13:38:02 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
tags 20148 fixed
close 20148 26.3
quit
> From a874f231ba0216ca2c3feedaae8ddb32f378f80e Mon Sep 17 00:00:00 2001
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 26 May 2019 12:04:56 +0200
> Subject: [PATCH] Fix docstring of bookmark-get-bookmark
>
> * bookmark.el (bookmark-get-bookmark): Fix docstring.
> ---
> lisp/bookmark.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index b1fe690dac..5c14f705eb 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el
> @@ -334,7 +334,9 @@ bookmark-get-bookmark
> If BOOKMARK-NAME-OR-RECORD is a string, look for the corresponding
> bookmark record in `bookmark-alist'; return it if found, otherwise
> error. Else if BOOKMARK-NAME-OR-RECORD is already a bookmark record,
> -just return it."
> +just return it.
> +Signal an error if bookmark is invalid. If optional argument
> +NOERROR is non-nil, return nil instead."
> (cond
> ((consp bookmark-name-or-record) bookmark-name-or-record)
> ((stringp bookmark-name-or-record)
The docstring already mentioned signalling an error, so I tweaked your
patch to include only the second of the two new sentences, as well as to
mention the full relative file name (lisp/bookmark.el) and the bug
reference (bug#20148) in the commit log, and pushed to emacs-26[1], and
am therefore closing this report.
[1: 1b2f83bb79]: Fix docstring of bookmark-get-bookmark
2019-05-30 13:32:10 +0100
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1b2f83bb7984269b92eb0afb323e3e74baf87068
Thanks,
--
Basil