[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35968: Proposed clean-compile patches for release 26.3
|
From: |
Paul Eggert |
|
Subject: |
bug#35968: Proposed clean-compile patches for release 26.3 |
|
Date: |
Thu, 30 May 2019 15:30:15 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 5/30/19 7:03 AM, Eli Zaretskii wrote:
This hunk seems to be just an aesthetic cleanup. Does it cause any
warnings/errors during compilation? If not, I'd prefer to leave it
out, for paranoia reasons.
Yes, if the hunk is omitted, _fraghead is defined twice and GCC complains:
gmalloc.c:353:20: error: redundant redeclaration of ‘_fraghead’
[-Werror=redundant-decls]
353 | static struct list _fraghead[BLOCKLOG];
| ^~~~~~~~~
gmalloc.c:185:20: note: previous declaration of ‘_fraghead’ was here
185 | static struct list _fraghead[BLOCKLOG];
| ^~~~~~~~~
So I installed the patches as-is.