[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable
From: |
Noam Postavsky |
Subject: |
bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable |
Date: |
Sat, 01 Jun 2019 20:11:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
tags 12857 fixed
close 12857 27.1
quit
Daniel Ralston <wubbulous@gmail.com> writes:
> That's a much cleaner way of doing it. I hadn't really looked into
> composite types before, so thanks for the suggestion!
>> This is a good patch! In my opinion it would be nicer if we use a
>> composite customization type for rcirc-default-part-reason and
>> rcirc-default-quit-reason, letting the user choose between the default
>> (rcirc-id-string) and a custom message.
I removed the part that puts the default into the customization type,
since the customization machinery already handles default values just
fine. Pushed to master, with followup NEWS entry.
aa9d57eed1 2019-06-01T20:01:43-04:00 "; Add NEWS entry for previous change"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aa9d57eed17ee6a8006c9cdd4f8636100482cd71
d3f14ffae4 2019-06-01T20:01:43-04:00 "Make rcirc PART and QUIT reasons
customizable (Bug#12857)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d3f14ffae4078688a57acdff30fdd91747386f17
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable,
Noam Postavsky <=