[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36337: 26.1; XBM images are sometimes not displayed correctly
From: |
Eli Zaretskii |
Subject: |
bug#36337: 26.1; XBM images are sometimes not displayed correctly |
Date: |
Sun, 23 Jun 2019 17:29:31 +0300 |
> From: Pip Cet <pipcet@gmail.com>
> Date: Sun, 23 Jun 2019 08:05:55 +0000
> Cc: 36337@debbugs.gnu.org
>
> The code does indeed assume that it is passed a bool vector which is
> padded to a multiple of 8 bits per line, but doesn't verify that the
> bool vector it is passed indeed matches this format, so it displays
> past the end of the bool vector.
>
> This is easy enough to fix by rewriting the bool vector, but that's
> potentially very slow (on debug builds), so maybe we shouldn't do
> that?
>
> Does the attached patch work for you?
Thanks, but I really hope there's a more elegant solution. If not,
maybe we should simply require that both width and height be an
integral multiple of 8 in this case.
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Markus Triska, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Markus Triska, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly,
Eli Zaretskii <=
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Eli Zaretskii, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/23
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Eli Zaretskii, 2019/06/28
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/28
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Eli Zaretskii, 2019/06/28
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/29
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Eli Zaretskii, 2019/06/29
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Pip Cet, 2019/06/29
- bug#36337: 26.1; XBM images are sometimes not displayed correctly, Eli Zaretskii, 2019/06/29