[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes
From: |
Andreas Schwab |
Subject: |
bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes |
Date: |
Wed, 26 Jun 2019 10:50:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) |
On Jun 25 2019, Drew Adams <drew.adams@oracle.com> wrote:
>> Oh, btw, this patch line
>>
>> (looking-at-p (char-to-string dired-marker-char))
>>
>> is not good if dired-marker-char is a regexp special like . or ?, I
>> guess (regexp-quote missing)?
>
> It's a good point; it would be clearer to wrap the
> arg to `looking-at-p' with `regexp-quote'.
I think it's better to say (eq (char-after) dired-marker-char).
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Lars Ingebrigtsen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Drew Adams, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Lars Ingebrigtsen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Michael Heerdegen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Lars Ingebrigtsen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Michael Heerdegen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Lars Ingebrigtsen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Drew Adams, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Michael Heerdegen, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Drew Adams, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes,
Andreas Schwab <=
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Drew Adams, 2019/06/26
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Drew Adams, 2019/06/25
- bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Michael Heerdegen, 2019/06/25
bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes, Lars Ingebrigtsen, 2019/06/25