[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention
From: |
Pip Cet |
Subject: |
bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors |
Date: |
Fri, 28 Jun 2019 09:28:53 +0000 |
On Fri, Jun 28, 2019 at 8:13 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > While I was there, I've also made it accept upper-case hex digits
> > (previously, #0F0 was accepted but #F00 wasn't), and fixed the ranges
> > so rgb:f/f/f translates to (65535 65535 65535) rather than (255 255
> > 255).
>
> Thanks.
Thanks for the very patient review. Sorry for making so many mistakes.
> > - (cond ((and (>= len 4) ;; X-style "#XXYYZZ" color spec
> > + (cond ((and (>= len 4) ;; "#XXYYZZ" color spec
>
> Is #XXYYZZ no longer considered "X-style"?
I would say no, since X's interpretation of #f00 is a little different
from the HTML/CSS/SVG interpretation.
> > ;; Translate the string "#XXYYZZ" into a list
> > - ;; of numbers (XX YY ZZ). If the primary colors
> > - ;; are specified with less than 4 hex digits,
> > - ;; the used digits represent the most significant
> > - ;; bits of the value (e.g. #XYZ = #X000Y000Z000).
> > + ;; of numbers (XX YY ZZ). If fewer than 4 hex
> > + ;; digits are used, they represent the fraction
> > + ;; of the maximum value (#XYZ = #XXXXYYYYZZZZ).
>
> IMO, this part makes the text confusing:
Thanks, you're absolutely right.
> Finally, this is just part of the patch, isn't it? The xterm.c part
> is not here, and neither are the documentation parts. Did I miss
> something?
Complete updated patch attached.
0001-Use-the-CSS-convention-for-RGB-colors-bug-36304.patch
Description: Text Data
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/20
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Richard Stallman, 2019/06/20
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/22
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors,
Pip Cet <=
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Robert Pluim, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Andy Moreton, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Pip Cet, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Eli Zaretskii, 2019/06/28
- bug#36304: 27.0.50; request: switch to the superior HTML #RGB convention for colors, Andy Moreton, 2019/06/28