|
From: | Paul Eggert |
Subject: | bug#36405: 26.2.90; O_PATH problem on some versions of Cygwin |
Date: | Fri, 28 Jun 2019 23:26:09 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 |
Eli Zaretskii wrote:
What problems did you see/envision on other platforms with the original patch?
Mainly the hassle of maintaining code with a lot of hard-to-read ifdefs in it. It's better if system-specific stuff is kept to a minimum in mainline code. Also, this O_PATH stuff is not that high of a priority, as the code works quite well in practice without O_PATH. (Also, if Cygwin botched O_PATH on FIFOs there's a reasonable chance it botched O_PATH elsewhere too. :-)
How about something like the attached patch instead? It's simpler and should be a bit faster on Cygwin than the original patch. I haven't tested it.
cygwin.diff
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |