[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36591: 26.2; Term's pager seems broken
From: |
Noam Postavsky |
Subject: |
bug#36591: 26.2; Term's pager seems broken |
Date: |
Tue, 23 Jul 2019 09:53:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) |
Adam Bliss <abliss@gmail.com> writes:
> I hope that this is helpful in tracking down the bug.
Thanks for doing this, it was very helpful. That commit looks like a
pretty innocent refactoring, but it actually reverses the sense of the
EQ (p->filter, Qt) check, because the pset_filter call is moved earlier.
So the bug can be fixed by adding a single '!'. Eli, any chance of
having this fix in the release branch?
--- i/src/process.c
+++ w/src/process.c
@@ -1230,7 +1230,7 @@ set_process_filter_masks (struct Lisp_Process *p)
{
if (EQ (p->filter, Qt) && !EQ (p->status, Qlisten))
delete_read_fd (p->infd);
- else if (EQ (p->filter, Qt)
+ else if (!EQ (p->filter, Qt)
/* Network or serial process not stopped: */
&& !EQ (p->command, Qt))
add_process_read_fd (p->infd);
- bug#36591: 26.2; Term's pager seems broken, Adam Bliss, 2019/07/11
- bug#36591: 26.2; Term's pager seems broken,
Noam Postavsky <=
- bug#36591: 26.2; Term's pager seems broken, Eli Zaretskii, 2019/07/23
- bug#36591: 26.2; Term's pager seems broken, Adam Bliss, 2019/07/23
- bug#36591: 26.2; Term's pager seems broken, Noam Postavsky, 2019/07/23
- bug#36591: 26.2; Term's pager seems broken, Eli Zaretskii, 2019/07/24
- bug#36591: 26.2; Term's pager seems broken, Noam Postavsky, 2019/07/24
- bug#36591: 26.2; Term's pager seems broken, Lars Ingebrigtsen, 2019/07/25
- bug#36591: 26.2; Term's pager seems broken, Eli Zaretskii, 2019/07/25
- bug#36591: 26.2; Term's pager seems broken, Lars Ingebrigtsen, 2019/07/25
- bug#36591: 26.2; Term's pager seems broken, Noam Postavsky, 2019/07/25
- bug#36591: 26.2; Term's pager seems broken, Lars Ingebrigtsen, 2019/07/25