[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters
From: |
Basil L. Contovounesios |
Subject: |
bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters |
Date: |
Sat, 27 Jul 2019 23:03:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> Any more comments, anyone?
Just a couple of very minor questions from me:
Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> -(defun dired--no-subst-prompt (char-positions command)
> +(defun dired--mark-positions (positions)
> + (let ((markers (make-string
> + (1+ (apply #'max positions))
Is POSITIONS guaranteed to be non-nil? (The max function takes at least
one argument.)
> Subject: [PATCH 6/6] Simplify highlighting assertions
>
> * test/lisp/dired-aux-tests.el (dired-test--check-highlighting):
> New function.
> (dired-test-highlight-metachar): Use it.
Will this simplification hinder debugging of test failures? I don't
have an opinion on the proposed change, it's just something to consider.
> Again, thank you for your patience and your reviews.
Thank you for working on this,
--
Basil
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/07/03
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/07/12
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Eli Zaretskii, 2019/07/27
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/07/27
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Michael Heerdegen, 2019/07/27
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Michael Heerdegen, 2019/07/28
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Juri Linkov, 2019/07/29
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/07/29
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters,
Basil L. Contovounesios <=
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/07/27
- bug#35564: [PATCH v4] Tweak dired warning about "wildcard" characters, Basil L. Contovounesios, 2019/07/27