[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34
bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el
Fri, 02 Aug 2019 18:16:59 +0200
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Tassilo Horn <address@hidden> writes:
>>> It can still be a bit improved in understandability and efficiency.
>>> 1. The function passed to replace-region-contents runs on the narrowed
>>> buffer anyway, so no need to narrow it yourself.
>>> 2. It would be better to create a temporary buffer, json-read
>>> repeatedly from the original buffer, json-encode/insert to the temp
>>> one, and then return the temp buffer.
>> Sounds like a good idea; please go ahead.
> Will do at the weekend.
Ok, I did it just now (10065010a6). Seems to work very well.