[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#37185: 24.5.1: vc--add-line, vc--remove-regexp are sub-optimal

From: Eli Zaretskii
Subject: bug#37185: 24.5.1: vc--add-line, vc--remove-regexp are sub-optimal
Date: Mon, 26 Aug 2019 09:44:10 +0300

> From: Wolfgang Scherer <address@hidden>
> Date: Sun, 25 Aug 2019 22:32:35 +0200
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 4cac153..bd0b601 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -1449,20 +1449,21 @@ Argument BACKEND is the backend you are using."
>  ;; Subroutine for `vc-git-ignore' and `vc-hg-ignore'.
>  (defun vc--add-line (string file)
>    "Add STRING as a line to FILE."
> -  (with-temp-buffer
> -    (insert-file-contents file)

Thank you for your contributions.  I expect them to be reviewed soon,
but let me point out that the patches you are sending (in this and
other bug reports) have 2 problems which will make their application
harder than necessary:

  . the whitespace is converted to 0x00a0 NBSP characters, which do
    not exist in the original sources
  . the patches lack commit log messages, in the format described in
    the file CONTRIBUTE in the top-level directory of the Emacs

It is best to generate your patches using "git format-patch" and then
send them as an attachment, I think this will solve these problems,
assuming that you commit locally with the appropriate log message as
described in CONTRIBUTE.

Thanks again for your interest in Emacs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]