[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of
From: |
Lars Ingebrigtsen |
Subject: |
bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file |
Date: |
Tue, 27 Aug 2019 09:14:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> IOW, there's no guarantee that markers will be preserved across
> operations that replace text.
No, but we have a small handful of functions that do best effort... but
they're deep in the C code and not accessible.
Finsert_file_contents has this:
/* Replacement should preserve point as it preserves markers. */
if (!NILP (replace))
{
window_markers = get_window_points_and_markers ();
record_unwind_protect (restore_point_unwind,
XCAR (XCAR (window_markers)));
}
...
handled:
if (inserted > 0)
restore_window_points (window_markers, inserted,
BYTE_TO_CHAR (same_at_start),
same_at_end_charpos);
The problem that this bug report addresses is that Lisp level functions
that implement special handlers for insert-file-contents (in this case,
epa-file-insert-file-contents) doesn't have access to the internals
necessary to give the user the same experience that the built-in version
gives the user.
My suggestion is basically to make DEFUN shims over
get_window_points_and_markers/restore_window_points, and create a new
macro `with-saved-markers' that would use that pair to do this cheap,
best-effort thing that Finsert_file_contents does.
> But I'm not opposed to adding support for string as the source for
> replacement. Just be aware that the code which access such a string
> must be highly optimized, because it is executed in the innermost loop
> of the code.
I just had a peek at the code, and it indeed highly optimised...
>> No wonder this function has gotten one single usage after it was
>> introduced two years ago. (Well, one usage to
>> replace-region-contents, which then calls the function.) (Unless
>> I'm grepping wrong.)
>
> replace-region-contents is used in json.el.
Yes, that's the one single usage of this machinery.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/26
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file,
Lars Ingebrigtsen <=
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/27
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/30
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Lars Ingebrigtsen, 2019/08/30
- bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file, Eli Zaretskii, 2019/08/30