[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37758: 27.0.50; Support multibyte characters in function 'auth-sourc
|
From: |
mgcyung |
|
Subject: |
bug#37758: 27.0.50; Support multibyte characters in function 'auth-source--pad'an; with patch |
|
Date: |
Tue, 15 Oct 2019 18:58:32 +0800 |
|
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (Gojō) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Yes. It works fine.
On Tue, 15 Oct 2019 14:43:58 +0800,
Lars Ingebrigtsen wrote:
>
> mgcyung <mgcyung@gmail.com> writes:
>
> > 'auth-source--pad' use 'length' to get byte length of a
> > string. However, 'length' return the number of characters which is not
> > the byte length with multibyte characters such as Chinese
> > character. This may causes an error "GnuTLS cipher
> > AES-256-CBC/encrypt input block length xxxx is not a multiple of the
> > required 16".
> >
> > According to the doc of 'length'. 'length' can be replaced by
> > 'string-bytes'. And a patch is attached.
>
> Thanks for the patch, but I don't think it's a quite safe change.
> Instead the string should be made into a sequence of bytes before
> padding (and converted back again afterwards) to ensure that it survives
> the encryption, I think.
>
> I've now made this change on the trunk. Could you check that it works
> for you?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no