bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32344: Add option to keep colorization in comint, use it in python.e


From: Juri Linkov
Subject: bug#32344: Add option to keep colorization in comint, use it in python.el
Date: Tue, 22 Oct 2019 23:37:31 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

>> But I wonder if you could just replace add-text-properties with
>> add-face-text-property?  It will keep your previous text properties
>> and will just merge them with the comint-highlight-input face.
>
> I'm not sure about this:
>
>> If any text in the region already has a non-nil ‘face’ property, those
>> face(s) are retained.
>
> Is the default face represented as a nil face property? Will it be
> overridden? In that case the mix could be ugly.

Merging with nil is a no-op anyway.

> In general I'd prefer to keep both paths of execution as separate as
> possible so as to avoid regressions.

The result would be very nice when font-lock faces that highlight keywords
are merged with the background color specified by the comint-highlight-input
face.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]