|
From: | Dmitry Gutov |
Subject: | bug#34343: [PATCH] Make project--find-regexp-in-files work with remote files |
Date: | Tue, 7 Jan 2020 17:34:38 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 07.01.2020 16:29, Michael Albinus wrote:
handler would be tramp-file-name-handler, so I don't see how it helps.
See my previous patch. It would only need one comparison, and file-remote-p wouldn't need to be mentioned.
Well, if you like the following piece of code, I guess we could live with that. (setq files (mapcar (if (tramp-tramp-file-p dir) #'tramp-file-local-name #'file-local-name) files)))That would work. If you are sure that you will handle only Tramp based remote files, you could simplify this to (setq files (mapcar #'tramp-file-local-name files))
Of course I'm not sure. Hence the conditional.
By the way, I have no idea what to do about having tramp-tramp-file-p called twice.Take the tramp-tramp-file-p call out of mapcar, like (let ((fun (if (tramp-tramp-file-p dir) #'tramp-file-local-name #'file-local-name))) (setq files (mapcar fun files)))
The above is pretty much equivalent.Anyway, please never mind. It's just one extra call to tramp-tramp-file-p. Not twice per each file.
[Prev in Thread] | Current Thread | [Next in Thread] |