[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20412: 25.0.50; Port not respected by ffap
From: |
Stefan Kangas |
Subject: |
bug#20412: 25.0.50; Port not respected by ffap |
Date: |
Wed, 15 Jan 2020 06:01:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> - Have the text '/ssh:root@127.0.0.1#2222:/root/' in buffer *scratch*.
>> - Put the cursor on the first slash.
>> - M-x find-file-at-point
>>
>> Result: the filespec with the port is not recognised.
>>
>> Patch proposal:
>
> [...]
>
>> - (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
>> + (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?#" "<@" "@>;.,!:")
>
> I wonder whether this will lead to more false positives than the number
> of times it'll help with this syntax here.
>
> But since it does test whether the file exists, perhaps it's not a
> problem anyway.
>
> Anybody got an opinion here?
I don't have a strong opinion either way. If we feel unsure about the
change, perhaps someone should try using this for a while to see how
well it works in practice.
Best regards,
Stefan Kangas
- bug#20412: 25.0.50; Port not respected by ffap,
Stefan Kangas <=