[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep
From: |
Stefan Monnier |
Subject: |
bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep |
Date: |
Mon, 20 Jan 2020 18:04:35 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> I'm not very familiar with the code. Do we really need the
>> minibuffer-force-complete call there? I commented it out and can't see
>> the difference.
The `minibuffer-force-complete` call is the one which actually selects
the "first candidate" from the list of completions, so I do think it's
necessary.
IIUC the bug under discussion is related to the `required` argument of
`completing-read` (and to `minibuffer-completion-confirm`).
If `required` was nil (as is the case in `grep-read-files` which
I believe is the relevant function here), then when `test-completion`
fails, we should probably just call `exit-minibuffer` (rather than tell
the user that they should do that).
The problem here is probably caused by the fact that fido-mode arranges
for `minibuffer-force-complete` to choose the *default* rather than to
choose a candidate from the completion table. It's rare for
a completion table to return candidates that don't pass
`test-completion` (tho it's by not impossible nor incorrect), but it's
much less rare for the default not to pass `test-completion`.
Stefan
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, (continued)
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/09
- Message not available
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/09
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/10
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, waah, 2020/01/10
- Message not available
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/11
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/17
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/19
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep,
Stefan Monnier <=
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/20
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/23
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/24
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Stefan Monnier, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, waah, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, João Távora, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Stefan Monnier, 2020/01/21
- bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep, Dmitry Gutov, 2020/01/21