>From c225cd8059607eeef0d65b57db31122e36b0471c Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Thu, 16 Jan 2020 01:23:46 +0100 Subject: [PATCH 2/3] Obsolete reftex-load-hook in favor of eval-after-load * lisp/textmodes/reftex-vars.el (reftex-load-hook): Make obsolete. * doc/misc/reftex.texi (Key Bindings, Keymaps and Hooks): No longer mention reftex-load-hook. (Bug#21563) --- doc/misc/reftex.texi | 9 ++------- lisp/textmodes/reftex-vars.el | 3 +++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/doc/misc/reftex.texi b/doc/misc/reftex.texi index 013c5639a1..0dab524151 100644 --- a/doc/misc/reftex.texi +++ b/doc/misc/reftex.texi @@ -2896,9 +2896,8 @@ Key Bindings Note that this variable has to be set before @RefTeX{} is loaded to have an effect. -@vindex reftex-load-hook -Changing and adding to @RefTeX{}'s key bindings is best done in the hook -@code{reftex-load-hook}. For information on the keymaps +Changing and adding to @RefTeX{}'s key bindings is best done using +@code{with-eval-after-load}. For information on the keymaps which should be used to add keys, see @ref{Keymaps and Hooks}. @node Faces @@ -5320,10 +5319,6 @@ Keymaps and Hooks The keymap for @RefTeX{} mode. @end deffn -@deffn {Normal Hook} reftex-load-hook -Normal hook which is being run when loading @file{reftex.el}. -@end deffn - @deffn {Normal Hook} reftex-mode-hook Normal hook which is being run when turning on @RefTeX{} mode. @end deffn diff --git a/lisp/textmodes/reftex-vars.el b/lisp/textmodes/reftex-vars.el index ca92541331..d2324dd4ae 100644 --- a/lisp/textmodes/reftex-vars.el +++ b/lisp/textmodes/reftex-vars.el @@ -2101,6 +2101,9 @@ reftex-load-hook :group 'reftex-miscellaneous-configurations :type 'hook) +(make-obsolete-variable 'reftex-load-hook + "use `with-eval-after-load' instead." "28.1") + (defcustom reftex-mode-hook nil "Hook which is being run when turning on RefTeX mode." :group 'reftex-miscellaneous-configurations -- 2.20.1